refactor(CL): change full range definition #6380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:x/superfluid
C:simulator
6 tasks
p0mvn
force-pushed
the
roman/min-spot-price-cont
branch
from
aa4d675 to
13a5552
Compare
p0mvn
commented
Sep 12, 2023
Comment on lines
49
to
55
| // Seed 1694529692 - proves issues in rounding direction of GetNextSqrtPriceFromAmount0InRoundingUp, proving | ||
| // that we must not QuoRoundUp for the last term in the formula. | ||
| // To repro: set up a breakpoint at the top of computeSwapOutGivenIn, and set count to 15. | ||
| // On the third (last) swap step for that swap, observe that the final `sqrtPriceNext` is off by one | ||
| // BigDec ULP, showing that this rounding bheavior was the issue. | ||
| r := rand.New(rand.NewSource(1694529692)) | ||
| s.individualFuzz(r, 0, 30, 10) |
There was a problem hiding this comment.
Please see this seed.
If the change in #6379 is reverted, this will start running into infinite loop bugs.
p0mvn
commented
Sep 14, 2023
|
|
||
| // estimate the amount in to fund | ||
| amountZeroIn, _, _ := s.computeSwapAmounts(poolId, pool.GetCurrentSqrtPrice(), types.MinInitializedTick, true, false) | ||
| amountZeroIn, _, _ := s.computeSwapAmounts(poolId, pool.GetCurrentSqrtPrice(), types.MinInitializedTickV2, true, false) |
p0mvn
force-pushed
the
roman/min-spot-price-cont
branch
from
cacdf04 to
cc63dd6
Compare
|
Context on latest commit in the PR: Still getting error that #6379 was attempting to get resolved. The investigations have shown that this is an acceptable case where non-zero amount in would yield a zero amount out. So we can adjust our fuzzed to never hit such cases. Fuzzer change is still WIP and needs more tweaking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes:
What is the purpose of the change
Changes the notion of full range to the extended [10^-30, 10^30].
Refactors all remaining logic, including superfluid to utilize the new price range. Removes any previously added fuzzer restrictions. Changes
DefaultMinTickto the V2 tick in tests.Testing and Verifying
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)